Broken builds

Post by Magnus Fromreide
I looks like the change 9641b472ef01208f92631016e91b0a4a518163f0 (openssl
1.1.0: Fix several build errors) broke the build on machines where openssl
is missing, I suppose this wasn't intentional?

Hello Magnus,

Indeed ... the goal was to fix build errors instead of introducing new
build errors. What build breakage did you encounter?

Bart.

Magnus Fromreide

2017-05-04 21:52:53 UTC

Hello Magnus,
Indeed ... the goal was to fix build errors instead of introducing new
build errors. What build breakage did you encounter?

I have a host where openssl isn't installed.

I am trying to compile apps/snmpusm.c.

On this host, HAVE_DH_GET0_PQG obviously isn't defined and so the
#if !defined(HAVE_DH_GET0_PQG) on line 126 is triggered.
On line 129 the source then tries to include <openssl/dh.h> but that fails
since openssl ain't installed.

/MF

Post by Bart Van Assche
Bart.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Net-snmp-coders mailing list
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Bart Van Assche

2017-05-06 00:31:06 UTC

Indeed ... the goal was to fix build errors instead of introducing new
build errors. What build breakage did you encounter?

I have a host where openssl isn't installed.
I am trying to compile apps/snmpusm.c.
On this host, HAVE_DH_GET0_PQG obviously isn't defined and so the
#if !defined(HAVE_DH_GET0_PQG) on line 126 is triggered.
On line 129 the source then tries to include <openssl/dh.h> but that fails
since openssl ain't installed.

Hello Magnus,

This should now also have been fixed.

Bart.

Magnus Fromreide

2017-05-07 03:48:36 UTC

Indeed ... the goal was to fix build errors instead of introducing new
build errors. What build breakage did you encounter?

I have a host where openssl isn't installed.
I am trying to compile apps/snmpusm.c.
On this host, HAVE_DH_GET0_PQG obviously isn't defined and so the
#if !defined(HAVE_DH_GET0_PQG) on line 126 is triggered.
On line 129 the source then tries to include <openssl/dh.h> but that fails
since openssl ain't installed.

Hello Magnus,
This should now also have been fixed.

Yes, this exact issue is fixed but there is a similar issue regarding
HAVE_DH_GET0_KEY in the DH_get0_key function right below DH_get0_pqg.

/MF

Bart Van Assche

2017-05-09 05:21:03 UTC

Indeed ... the goal was to fix build errors instead of introducing new
build errors. What build breakage did you encounter?

I have a host where openssl isn't installed.
I am trying to compile apps/snmpusm.c.
On this host, HAVE_DH_GET0_PQG obviously isn't defined and so the
#if !defined(HAVE_DH_GET0_PQG) on line 126 is triggered.
On line 129 the source then tries to include <openssl/dh.h> but that fails
since openssl ain't installed.

Hello Magnus,
This should now also have been fixed.

Yes, this exact issue is fixed but there is a similar issue regarding
HAVE_DH_GET0_KEY in the DH_get0_key function right below DH_get0_pqg.

Hello Magnus,

That issue should now also be fixed. Sorry that I had overlooked it.

Bart.

Magnus Fromreide

2017-05-09 06:17:54 UTC